#210 - Add CalVer version surfaces#212
Merged
Merged
Conversation
Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
Contributor
|
| Filename | Overview |
|---|---|
| CMakeLists.txt | Reads CalVer version from VERSION file with a regex guard, configures daqiri_version.h.in, and changes CMake package compatibility from SameMajorVersion to AnyNewerVersion to decouple year-based CalVer from ABI versioning (tracked separately via SOVERSION). |
| cmake/daqiri_version.h.in | New CMake-configured header exposing DAQIRI_VERSION macro, CalVer component macros, DAQIRI_ABI_VERSION, and inline constexpr helpers in the daqiri namespace — clean, header-only, noexcept. |
| src/metrics.cpp | Replaces hardcoded "0.1.0" with version_string() for the OTel meter version; unqualified call resolves correctly to daqiri::version_string() via C++ enclosing-namespace lookup from daqiri::metrics. |
| python/daqiri_common_pybind.cpp | Exposes version, version_info, abi_version module attributes plus version_string/year/month/patch/abi_version functions via pybind11; correctly bridges the C++ constexpr values to Python. |
| python/pybind11/init.py | Re-exports version, version_info, and abi_version explicitly — necessary because wildcard import skips dunder attributes from C extensions. |
| src/CMakeLists.txt | Threads DAQIRI_GENERATED_INCLUDE_DIR into daqiri_common and per-engine include paths, and sets VERSION/SOVERSION on the shared library targets — correctly decouples CalVer from ABI version. |
| include/daqiri/daqiri.h | Single-line addition including daqiri/version.h, making version macros and helpers available to any consumer of the public header. |
| VERSION | New single-line file containing 2026.7.0; correctly formatted CalVer that passes the CMake regex validator. |
| docs/api-reference/cpp.md | Adds a Version Metadata section with usage examples and table entries for the new version/abi functions — complete and accurate. |
| docs/api-reference/python.md | Documents daqiri.version, version_info, abi_version, and version helper functions with a working code example; table entries for the new constants are added. |
| docs/getting-started.md | Adds CalVer find_package usage example, pkg-config modversion command, and a note on daqiri/version.h — matches the new CMake and header behavior. |
| AGENTS.md | Adds CalVer description to CMake options section and public API section; removes stale :137 line-number anchor from the docs drift hotspot list. |
Reviews (2): Last reviewed commit: "#210 - Add CalVer version surfaces" | Re-trigger Greptile
Collaborator
|
I agree with the Greptile suggestion to make the first version 2026.07.0 to match the YYYY.MM.PATCH template. Otherwise, looks good to me! |
Collaborator
Author
|
@greptile review |
RamyaGuru
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CalVer versioning with gettable interfaces.